Open
Conversation
nayeemrmn
approved these changes
Sep 3, 2025
dsherret
force-pushed
the
branch_v5.9.2_patch
branch
3 times, most recently
from
462776e to
e4d7b58
Compare
dsherret
force-pushed
the
branch_v5.9.2_patch
branch
from
33c4e5e to
7935ec8
Compare
bartlomieju
pushed a commit
to denoland/deno
that referenced
this pull request
Dec 9, 2025
This adds a new "node" lib that's included by default and can be excluded by providing a custom `"lib": [...]` typescript compiler option without the `"node"` value. If it detects a `@types/node` package in the files being type checked it will skip injecting the `lib.node.d.ts` file. * Uses `npm:@types/node@24.2.0` * See tools/update_types_node.ts for the build script. * denoland/deno_npm#127 (will integrate this one later) * denoland/typescript-go#16 * denoland/TypeScript#19 (last two commits) Closes #30963
dsherret
force-pushed
the
branch_v5.9.2_patch
branch
from
3dcbc05 to
c5cb3b2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remotes:
Actions:
git fetch upstreamgit checkout upstream/release-5.9and ensured it was on the commit of the release.git checkout -b branch_v5.9.2git push denolandgit checkout -b branch_v5.9.2_patchdenoland/branch_5.8.3_patchintodenoland/branch_v5.9.2_patchand squashed the commitsnpm install && npx hereby services dts-services(to build)globalsorglobalThisSymbolnot existing, it's because they're calleddenoGlobals/nodeGlobalsanddenoGlobalThisSymbol/nodeGlobalThisSymbolin this forkglobalsorglobalThisSymbolin checker.ts, update that code to be properly handled using eitherdenoGlobals/nodeGlobalsordenoGlobalThisSymbol/nodeGlobalThisSymbol(note:globalThisTyperefers to the globalthistype and not the globalglobalThistype)cp built/local/typescript.js ../deno/cli/tsc/00_typescript.jsbuilt/localto../deno/cli/tsc/dtsthen deleted files that didn't seem necessary (ex. typescript.internal.d.ts).ScriptElementKindin the ts codebase has changed and if so, align withScriptElementKindin cli/lsp/tsc.rscargo test checkandcargo test lsphttps://github.com/denoland/deno/tree/main/cli/tsc#how-to-upgrade-typescript